Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL

Поиск
Список
Период
Сортировка
От Önder Kalacı
Тема Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL
Дата
Msg-id CACawEhUCg-tRGzRqRq+qHaR+kPdZ=N1fP=A4_cCYd0LuNLUgnA@mail.gmail.com
обсуждение исходный текст
Ответ на RE: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL  ("shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>)
Ответы Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL  (Amit Kapila <amit.kapila16@gmail.com>)
Список pgsql-hackers
Дерево обсуждения
Hi Shi Yu,


1.
@@ -243,6 +243,17 @@ tuples_equal(TupleTableSlot *slot1, TupleTableSlot *slot2,
                Form_pg_attribute att;
                TypeCacheEntry *typentry;

+
+               Form_pg_attribute attr = TupleDescAttr(slot1->tts_tupleDescriptor, attrnum);
+

I think we can use "att" instead of a new variable. They have the same value.

ah, of course :) 
 

2.
+# The bug was that when when the REPLICA IDENTITY FULL is used with dropped

There is an extra "when".


Fixed, thanks


Attaching v2 
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Önder Kalacı
Дата:
Сообщение: Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher
Следующее
От: Dean Rasheed
Дата:
Сообщение: Re: Supporting MERGE on updatable views