Re: Function array_agg(array)

Поиск
Список
Период
Сортировка
От Ali Akbar
Тема Re: Function array_agg(array)
Дата
Msg-id CACQjQLpdm_Jjd4Tca811HKSS+HNRzrye0jCj=nXfkEtuJdku+g@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Function array_agg(array)  (Pavel Stehule <pavel.stehule@gmail.com>)
Список pgsql-hackers
super

I tested last version and I have not any objections.

1. We would to have this feature - it is long time number of our ToDo List

2. Proposal and design of multidimensional aggregation is clean and nobody has objection here.

3. There is zero impact on current implementation. From performance reasons it uses new array optimized aggregator - 30% faster for this purpose than current (scalar) array aggregator

4. Code is clean and respect PostgreSQL coding rules

5. There are documentation and necessary regress tests

6. Patching and compilation is clean without warnings.

This patch is ready for commit

Thank you for patch

Thank you for the thorough review process.
 
Regards,
--
Ali Akbar

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: proposal: CREATE DATABASE vs. (partial) CHECKPOINT
Следующее
От: Marti Raudsepp
Дата:
Сообщение: Re: alter user/role CURRENT_USER