Re: Last Commitfest patches waiting review

Поиск
Список
Период
Сортировка
От Ali Akbar
Тема Re: Last Commitfest patches waiting review
Дата
Msg-id CACQjQLoqzE06Ra9FZ5cmyzCPzKi94Ot0bbEmuvmqmKR_byNYRQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Last Commitfest patches waiting review  (Heikki Linnakangas <hlinnakangas@vmware.com>)
Список pgsql-hackers
Дерево обсуждения
2014-10-03 23:14 GMT+07:00 Heikki Linnakangas <hlinnakangas@vmware.com>:
Fix xpath() to return namespace definitions (fixes the issue with nested or repeated xpath())

   Peter, you've done some XML stuff before; could you have a look at this too?

I am the author of the patch. I've sent Peter off-the-list review request email as you had suggested before, but he didn't respond.

How can i help to ease the review? The last patch is re-implementation, as per Tom Lane's findings about xmlNodeCopy's behavior if there's not enough memory. It turns out that the reimplementation is not as simple as before (because reimplement some of xmlNodeCopy code must be reimplemented here).

Reviewing the patch myself, i've  found some code formatting problems. Will fix and post in the patch's thread.

Regards,
--
Ali Akbar

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: Failure with make check-world for pgtypeslib/dt_test2 with HEAD on OSX
Следующее
От: Ali Akbar
Дата:
Сообщение: Re: [REVIEW] Re: Fix xpath() to return namespace definitions