On Sat, Mar 30, 2019 at 11:18 AM Jerry Jelinek <jerry.jelinek@joyent.com> wrote: > I went through your new version of the patch and it all looks great to me.
I moved the error handling logic around a bit so we'd capture errno immediately after the syscalls. I also made a couple of further tweaks to comments and removed some unnecessary casts.
I suspect we took so long on this because of lack of ZFS knowledge and uncertainty about the precise reason for the current coding in terms of crash safety in general. After learning more, I now suspect the claim about fsyncdata(2) and indirect blocks in the comments may be incorrect (it may stem from buggy behaviour on older Linux kernels), but I'm not sure and it's not this patch's job to change that.
Pushed. Thanks for the patch!
Thanks a lot for getting this integrated, and thanks to everyone else who gave me so much feedback and assistance during this process!