On Tue, May 7, 2019 at 4:00 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, May 07, 2019 at 03:41:50PM +0800, John Naylor wrote:
> > Attached is an attempt to match surrounding code. More broadly,
> > though, it seems the "ID info" comments belong with the SET_LOCKTAG_*
> > macros rather than with the LockTagType enum members.
>
> + LOCKTAG_SPECULATIVE_TOKEN, /* for speculative insertion */
> + /* ID info for a speculative token is TRANSACTION info + token */
> Shouldn't the first comment be just "speculative insertion"?
That's probably better.
> And the
> second one "ID info for a speculative insertion is transaction ID +
> its speculative insert counter"?
I was just going by the variable name at hand, but more precision may be good.
--
John Naylor https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services