Re: read stream on amcheck

Поиск
Список
Период
Сортировка
От jian he
Тема Re: read stream on amcheck
Дата
Msg-id CACJufxH8eK_yEk3Sn=W+zfvQEp8sCDWfwqcsLd8A7GiEhZF7NQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: read stream on amcheck  (Kirill Reshke <reshkekirill@gmail.com>)
Список pgsql-hackers
Дерево обсуждения 
On Fri, Jan 3, 2025 at 1:53 AM Matheus Alcantara
<matheusssilv97@gmail.com> wrote:
>
>
> Yeap, I agree. Attached a v2 fixed.
>

hi. some minor issue i found.

+#include "storage/block.h"
no need, since "#include "storage/bufmgr.h" already included it.

do we need to add ``CHECK_FOR_INTERRUPTS()`` in heapam_read_stream_next_block?

heapam_read_stream_next_block_private need add to
src/tools/pgindent/typedefs.list

overall, it looks good to me.

В списке pgsql-hackers по дате отправления: