PartitionKeyData->partattrs, refactor some 0 to InvalidAttrNumber

Поиск
Список
Период
Сортировка
От jian he
Тема PartitionKeyData->partattrs, refactor some 0 to InvalidAttrNumber
Дата
Msg-id CACJufxGmsphWX150CxMU6KSed-x2fmTH3UpCwHpedGmjV1Biug@mail.gmail.com
обсуждение исходный текст
Ответы Re: PartitionKeyData->partattrs, refactor some 0 to InvalidAttrNumber
Список pgsql-hackers
hi.

if PartitionKeyData->partattrs is 0, then it means that partition key is
expression, else it's column reference.

we can change from
if (key->partattrs[i] == 0)
to
if (key->partattrs[i] == InvalidAttrNumber)

the reason I can think of is to improve grepability.
numeric value 0 is too common to reliably locate relevant code.

what do you think?

--
jian
https://www.enterprisedb.com/

Вложения

В списке pgsql-hackers по дате отправления: