Re: Raise an exception under Python < 3.4

Поиск
Список
Период
Сортировка
От Neel Patel
Тема Re: Raise an exception under Python < 3.4
Дата
Msg-id CACCA4P3nStvuuS2PYjRnsWHKVTq1aOc3vpw6LwRKcTDAi674uA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Raise an exception under Python < 3.4  (Dave Page <dpage@pgadmin.org>)
Список pgadmin-hackers
Hi,

On Wed, Apr 29, 2020 at 2:52 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Apr 29, 2020 at 10:13 AM Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Patch looks good to me except one condition as we do support from Python 3.4 onwards. I have modified that condition and attached the updated patch.

What did you change exactly (curious about what I missed)?

Previously it was like,

+if sys.version_info < (3, 3):
+    raise Exception('This application must be run under Python 3.4 or later.')
 
Modified as below.

+if sys.version_info < (3, 4):

+    raise Exception('This application must be run under Python 3.4 or later.')



 

I have also removed the other references of Python2. Attached is the patch. Do review it and let me know for comments.

I think there's a lot more than that - try searching the entire tree for PY2 or sys.version. This was on my personal todo as a next step, but feel free to update your patch :-)

Sure.
 

Thanks!
 

Thanks,
Neel Patel

On Mon, Apr 27, 2020 at 9:27 PM Dave Page <dpage@pgadmin.org> wrote:
The attached patch raises an exception if run under Python < 3.4. It also cleans up the README to remove references to Python 2 and removes Python 2-isms from the main config.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Dave Page
Дата:
Сообщение: Re: Raise an exception under Python < 3.4
Следующее
От: Yogesh Jain
Дата:
Сообщение: Re: [pgAdmin][RM4279] : Issue with File Browser Home button