Hi Surinder,
We have applied/tested the patch and below are the review comments.
1. When we select the extension "plpython3u", "plperl", "plperu" etc. then it gives 'TypeError' in Javascript.
TypeError: d.version is undefined
'version': (!_.isNull(d.version[0]) ? d.version[0]: '')
We are getting this error while selecting many extensions so please test with all types of extensions, it should not give any error at client side.
2. Use 2 space indentation instead of 4 space in javascript file.
3. In "validate" function in "extension.js" file, validate only the changed values not all, and "this.get('name') - should be called only one time not multiple
time".
4. When we pass object identifier, use the function 'qtIdent', and for the values, use function 'qtLiteral' in all the sql files.
5. By default, when we create the extension, "schema_name" and "version" should not be be set with value. It should be set blank by default.
6. When we create any extension like "citext" then we are not able to create the same extension again after deleting the same extension. May be issue
with caching mechanism.
7. When we remove the schema_name during the "Edit" operation then wrong SQL is getting generated.
8. Remove "Use Slony" option. As discussed with Ashesh, we will implement it as separate module.
Please fix the above issues. Let us know if you want more information.
Thanks,
Neel Patel
Thanks,
Neel Patel