Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390

Поиск
Список
Период
Сортировка
От Neel Patel
Тема Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390
Дата
Msg-id CACCA4P1Rm1Z1em+XMO5qy3Ne=ckyMMbUeffsNKPWti1z7Abziw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390  (Neel Patel <neel.patel@enterprisedb.com>)
Ответы Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390  (Dave Page <dpage@pgadmin.org>)
Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390  (Nikolai Zhubr <n-a-zhubr@yandex.ru>)
Список pgadmin-hackers
Hi,

Please find attached patch file with below fix.
 - Return value of the function will be displayed as "SETOF record" instead of "SETOF SETOF record" under SQL tab within properties window.

Let me know for any comments.

Thanks,
Neel Patel

On Tue, Jan 5, 2016 at 5:08 PM, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Dave,

Sure, I will look into this issue.

Thanks,
Neel Patel

On Tue, Jan 5, 2016 at 4:47 PM, Dave Page <dpage@pgadmin.org> wrote:
Neel, can you look at this please?

Thanks.

On Tue, Jan 5, 2016 at 11:01 AM, Nikolai Zhubr <n-a-zhubr@yandex.ru> wrote:
> Hi all,
>
> Running 1.22-rc1 now I observe that this commit has apparently still not
> solved the issue in at least one place. That is:
>
> - "RETURNS SETOF record" is correctly displayed in SQL panel now.
>
> - "RETURNS SETOF SETOF record" is still erroneously displayed under SQL tab
> within the properties window (effectively preventing set-returning function
> to be changed in any way through the properties window).
>
>
> Thank you,
> Nikolai
>
> 12.10.2015 5:33, Ashesh Vashi:
>>
>> As per commit:600daf650bd5e50e664c4ece2e53e95446390b6d, we now use
>> pg_get_function_result(..) function to identify the return type of the
>> function, hence - we don't need to add SETOF keyword explicitly, when a
>> function returns set of records.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>>
>> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=9d7596dc552cf9315d4aa83eafe19db1acf7e531
>>
>> Modified Files
>> --------------
>> pgadmin/schema/pgFunction.cpp |    2 --
>> 1 file changed, 2 deletions(-)
>>
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: Neel Patel
Дата:
Сообщение: Re: pgAdmin III commit: As per commit:600daf650bd5e50e664c4ece2e53e95446390
Следующее
От: Murtuza Zabuawala
Дата:
Сообщение: PATCH: Minor patch to fix 'qtLiteral' function in pgAdmin4