Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable tolaunch query tool and debugger in new browser tab
От | Neel Patel |
---|---|
Тема | Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable tolaunch query tool and debugger in new browser tab |
Дата | |
Msg-id | CACCA4P0eYUkFBz5ZwC1d5gM=LYwDRAcXRGRr4gfag_9SUmhPjg@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable tolaunch query tool and debugger in new browser tab (Dave Page <dave.page@enterprisedb.com>) |
Ответы |
Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable tolaunch query tool and debugger in new browser tab
|
Список | pgadmin-hackers |
Hi Dave,
Here there are 2 compilation issue. We have fixed 'QNetworkCookieJar' related compilation error in Qt4. BUT
Below compilation error is coming because we have not applied the latest patch of webkit which was fixed in annulen/webkit repo which was raised at below path.
BrowserWindow.cpp:842:59: error: ‘RequestClose’ is not a member of ‘QWebPage’
webviewPtr->page()->triggerAction(QWebPage::RequestClose);
To fix the above compilation error currently we have two solution.
- Apply the given patch in webkit ( qwebpage.cpp & qwebpage.h file ) .
- Comment the below line temporary for compilation until we get the releases from annulen/webkit.
webviewPtr->page()->triggerAction(QWebPage::RequestClose);
Other compilation issues, (Me and Akshay) will fix and commit it but need your input on above issue.
Thanks,
Neel Patel
On Tue, May 9, 2017 at 2:02 PM, Dave Page <dave.page@enterprisedb.com> wrote:
It's running CentOS 7.3, with packages from EPEL:[dpage@jenkins ~]$ rpm -qa |grep qtqt5-qtbase-common-5.6.1-10.el7.noarch qt5-qtbase-devel-5.6.1-10.el7.x86_64 qt-4.8.5-13.el7.x86_64qt5-qtbase-5.6.1-10.el7.x86_64qt5-qtxmlpatterns-5.6.1-10.el7.x86_64 qt5-qtwebchannel-5.6.1-10.el7.x86_64 qt5-qtwebkit-5.6.1-3.b889f46git.el7.x86_64 qt5-qtdeclarative-devel-5.6.1-10.el7.x86_64 qt-devel-4.8.5-13.el7.x86_64qt-settings-19-23.5.el7.centos.noarch qt5-qtbase-gui-5.6.1-10.el7.x86_64 qt5-qtlocation-5.6.1-10.el7.x86_64 qt5-qtwebsockets-5.6.1-10.el7.x86_64 qt5-qtwebkit-devel-5.6.1-3.b889f46git.el7.x86_64 qtwebkit-2.3.4-6.el7.x86_64qt3-3.3.8b-51.el7.x86_64qt5-qtdeclarative-5.6.1-10.el7.x86_64 qt5-rpm-macros-5.6.1-10.el7.noarch qtwebkit-devel-2.3.4-6.el7.x86_64 qt-x11-4.8.5-13.el7.x86_64qt5-qtsensors-5.6.1-10.el7.x86_64 On Tue, May 9, 2017 at 9:28 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:Hi Dave,Yes, It looks like compilation fails on Qt4. We will fix this issue but which version of Qt4 we are using in Jenkins ?Thanks,Neel PatelOn Tue, May 9, 2017 at 1:56 PM, Dave Page <dave.page@enterprisedb.com> wrote:On Tue, May 9, 2017 at 9:18 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: HiOn Tue, May 9, 2017 at 1:42 PM, Dave Page <dave.page@enterprisedb.com> wrote:This appears to have made Jenkins get all angry and red :-(We(Neel and I) have tested it and working fine.It clearly doesn't compile on QT4. Please review the Jenkins logs.--On Tue, May 9, 2017 at 8:39 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote: Thanks patch applied.--On Mon, May 8, 2017 at 3:21 PM, Dave Page <dpage@pgadmin.org> wrote:Akshay, could you review this please?Thanks.On Fri, May 5, 2017 at 11:53 AM, Neel Patel <neel.patel@enterprisedb.com> wrote:--Hi,Please find attached patch file with the fix of RM #2328 - [Runtime]: Unable to launch query tool and debugger in new browser tab.I have used Qt 5.8 with webkit mentioned in below URL.As there was a bug in QWebKit regarding "unload" event. We have raised and also they have provided patch file to fix this issue. I have applied the patch in linux and compile the webkit and tested the attached patch with compiled webkit which is now working fine.Below is the link for reference regarding unload issue. They have provided test webkit release for Mac in below URL but for other platform we need to apply the patch and compile the webkit until they provide webkit-releases for all platforms.Do review it and let me know in case of any issue.Thanks,Neel Patel
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers --Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL CompanyDave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake--Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake--Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
В списке pgadmin-hackers по дате отправления:
Предыдущее
От: Dave PageДата:
Сообщение: Re: [pgadmin-hackers] [pgAdmin4][runtime]: RM #2328 - Unable tolaunch query tool and debugger in new browser tab
Следующее
От: Murtuza ZabuawalaДата:
Сообщение: [pgadmin-hackers] [pgAdmin4][PATCH] To add handling of BOM character in query tool