Re: PG compilation error with Visual Studio 2015/2017/2019

Поиск
Список
Период
Сортировка
От Juan José Santamaría Flecha
Тема Re: PG compilation error with Visual Studio 2015/2017/2019
Дата
Msg-id CAC+AXB3q34+SMkLZMrDobpJnTmeLBhmnBfz7KmpRG=FSppfaFw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: PG compilation error with Visual Studio 2015/2017/2019  (Amit Kapila <amit.kapila16@gmail.com>)
Список pgsql-hackers
Дерево обсуждения


On Fri, Apr 10, 2020 at 2:25 PM Amit Kapila <amit.kapila16@gmail.com> wrote:

I see that the kind of check you are talking is recently added by
commit 352f6f2d.  I think it is better to be consistent in all places.
Let's pick one and use that if possible.

Currently there are two constructs to test the same logic, which is not great. I think that using _MSC_VER  makes it seem as MSVC exclusive code, when MinGW should also be considered.

In the longterm aligning Postgres with MS product obsolescence will make these tests unneeded, but I can propose a patch for making the test consistent in all cases, on a different thread since this has little to do with $SUBJECT.

Regards,

Juan José Santamaría Flecha
 

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: pg_validatebackup -> pg_verifybackup?
Следующее
От: Alexey Kondratov
Дата:
Сообщение: Re: [HACKERS] make async slave to wait for lsn to be replayed