Re: BUG #16108: Colorization to the output of command-line hasunproperly behaviors at Windows platform

Поиск
Список
Период
Сортировка
От Juan José Santamaría Flecha
Тема Re: BUG #16108: Colorization to the output of command-line hasunproperly behaviors at Windows platform
Дата
Msg-id CAC+AXB1yZXb_=DzRoPV8jY0cUX5EFYLHtmOgu7is3d3M31GppQ@mail.gmail.com
обсуждение исходный текст
Ответ на RE: BUG #16108: Colorization to the output of command-line has unproperly behaviors at Windows platform  ("Tang, Haiying" <tanghy.fnst@cn.fujitsu.com>)
Список pgsql-bugs
Дерево обсуждения
Thanks for testing. I am opening a new item in the next commitfest for this topic.

On Fri, Nov 15, 2019 at 5:23 AM Tang, Haiying <tanghy.fnst@cn.fujitsu.com> wrote:

>In order to make it work both things are needed, setting the console mode and a terminal that supports it.

 

Your patch worked fine on windows which supports VT100. But the bug still happened when set PG_COLOR="always" at Windows Terminal that not support VT100. Please see the attached file “Test_result.png” for the NG result. (I used win7 for this test)


To fix the above bug, I made some change to your patch. The new one works fine on my win7(VT100 not support) and win10(VT100 support).


My understanding of the "always" logic is that it has to be enabled no matter what, even if not supported in current output.

Also, in this new patch(v1), I added some doc change for Windows not support Colorization.  Please find the attached patch for so.

 

You cannot change the release notes, if anything it will be added to 12.2 patch notes. It should be added to the 21 (!) utilities that specify the PG_COLOR usage, but I am not so sure that adding a note stating this feature requires Windows 10 >= 1511 update is really a Postgres business.

Please find attached a version that supports older Mingw versions and SDKs.

Regards,

Juan José Santamaría Flecha 



Вложения

В списке pgsql-bugs по дате отправления:

Предыдущее
От: Michael Paquier
Дата:
Сообщение: Re: REINDEX CONCURRENTLY unexpectedly fails
Следующее
От: Floris Van Nee
Дата:
Сообщение: incorrect pg_dump output due to not handling dropped roles correctly