Re: pg_dump/pg_restore: Fix stdin/stdout handling of custom format on Win32
От | Juan José Santamaría Flecha |
---|---|
Тема | Re: pg_dump/pg_restore: Fix stdin/stdout handling of custom format on Win32 |
Дата | |
Msg-id | CAC+AXB110=KAhu2XMX45oPX6G9ePEGwUGtCC2c4AMXQcEuwAPw@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: pg_dump/pg_restore: Fix stdin/stdout handling of custom format on Win32 (Daniel Watzinger <daniel.watzinger@gmail.com>) |
Ответы |
Re: pg_dump/pg_restore: Fix stdin/stdout handling of custom format on Win32
|
Список | pgsql-hackers |
Please, don't top post.
On Tue, Mar 14, 2023 at 12:30 PM Daniel Watzinger <daniel.watzinger@gmail.com> wrote:
I'm sorry I couldn't contribute to the discussion in time. The fix of the fstat() Win32 port looks good to me. I agree that there's a need for multiple fseek() ports to address the shortcomings of the MSVC functionality.The documentation event states that "on devices incapable of seeking, the return value is undefined". A simple wrapper using GetFileType() or the new fstat(), to filter non-seekable devices before delegation, will probably suffice.
I have just posted a patch to enforce the detection of unseekable streams in the fseek() calls [1], please feel free to review it.
Regards,
Juan José Santamaría Flecha
В списке pgsql-hackers по дате отправления: