Re: test_extensions: fix inconsistency between meson.build and Makefile

Поиск
Список
Период
Сортировка
От Gurjeet Singh
Тема Re: test_extensions: fix inconsistency between meson.build and Makefile
Дата
Msg-id CABwTF4Wz41pNMJ9q3tpH=6mnvg6aopDU5Lzvers5=6=WJVekww@mail.gmail.com
обсуждение исходный текст
Ответ на Re: test_extensions: fix inconsistency between meson.build and Makefile  ("Tristan Partin" <tristan@neon.tech>)
Ответы Re: test_extensions: fix inconsistency between meson.build and Makefile  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
On Fri, Jun 16, 2023 at 1:56 PM Tristan Partin <tristan@neon.tech> wrote:
>
> On Fri Jun 16, 2023 at 3:29 PM CDT, Jeff Davis wrote:
> > Patch attached. Currently, the Makefile specifies NO_LOCALE=1, and the
> > meson.build does not.
>
> Looks alright to me, but it might be nicer to change the order of
> arguments to match contrib/unaccent/meson.build:40. Might help with
> grepping in the future.

It seems that Jeff's patch tried to match the precedent set in
src/test/modules/test_oat_hooks/meson.build.

No matter which ordering Jeff's patch uses, it will be inconsistent
with one of the existing order of the options.

So attached is updated patch that makes the order consistent across
all 3 occurrences.

Best regards,
Gurjeet
http://Gurje.et

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andrew Dunstan
Дата:
Сообщение: Re: run pgindent on a regular basis / scripted manner
Следующее
От: Evan Jones
Дата:
Сообщение: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific