Re: Thinko in pgstat_build_snapshot()

Поиск
Список
Период
Сортировка
От Gurjeet Singh
Тема Re: Thinko in pgstat_build_snapshot()
Дата
Msg-id CABwTF4WZxGN=1m6RGS2-G+pMXY-Ny02vmEG4u-1ua+z0oQ9O8A@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Thinko in pgstat_build_snapshot()  (Heikki Linnakangas <hlinnaka@iki.fi>)
Ответы Re: Thinko in pgstat_build_snapshot()
Список pgsql-hackers
On Sun, Mar 30, 2025 at 4:31 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>
> On 30/03/2025 13:23, Etsuro Fujita wrote:
> > While working on something else I noticed $SUBJECT: we are allocating
> > more memory than necessary and copying more data than necessary
> > because we specify the wrong PgStat_KindInfo member as the size
> > argument for MemoryContextAlloc and memcpy.  This could become
> > problematic if snapshotting a very large number of variables stats, so
> > I fixed it.  Attached is a patch for that.
>
> Good catch. Patch looks good to me at quick glance.

+1 on both counts.

Best regards,
Gurjeet
http://Gurje.et



В списке pgsql-hackers по дате отправления: