Re: pg_copy_logical_replication_slot doesn't copy the failover property

On Wed, Feb 19, 2025 at 12:40 PM Shlok Kyal <shlok.kyal.oss@gmail.com> wrote:
> Hi,
>
> The failover option is set to false by default while copying of the
> slots as it may cause some issue during slot synchronization as per
> discussion [1].
>
> I have created a patch to update the documentation for the same.
>

Thanks for the patch.
A couple of comments regarding the sentence:

+        not copied and set as <literal>false</literal> by default due to
+        potential issues with the slot synchronization.

1) / and set as/ and is set to
"set to" is more natural and clearer when assigning a specific value
compared to "set as."

2) "due to potential issues..." wording implies that it is addressing
existing issues. I feel it would be better to say:
"... <literal>false</literal> by default to avoid potential issues
with the slot synchronization."

--
Thanks,
Nisha