On Tue, Oct 6, 2020 at 8:45 PM Bruce Momjian <bruce@momjian.us> wrote:
On Tue, Oct 6, 2020 at 11:40:57AM +0200, Daniel Gustafsson wrote: > > On 6 Oct 2020, at 11:27, Magnus Hagander <magnus@hagander.net> wrote: > > > ISTM that code could be cleaned out, because it should be dead based on the initial check that we are upgrading from 8.4 or later? > > +1. Commit 2209b3923a7afe0b removed support for 8.3 so anything left checking > for pre-8.4 should be removed as a pre-8.4 source cluster couldn't be upgraded > with pg_upgrade today.
OK, fixed with the attached patch, applied to all branches. There was code that tested for >= 8.4 (useless test) or < 8.4 (dead code). I also adjusted the version tests to be consistent.
Thanks!
And yeah, I noticed the inconsistency in the checking as well. Getting that cleaned up was good.