Re: Capitalization of the name OpenSSL

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: Capitalization of the name OpenSSL
Дата
Msg-id CABUevEzLLp30d33darD3Of8sWBZBRzQW8PEehZyU-+NSZO7OOg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Capitalization of the name OpenSSL  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: Capitalization of the name OpenSSL  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers


On Thu, Jun 28, 2018 at 4:54 AM, Michael Paquier <michael@paquier.xyz> wrote:
On Thu, Jun 28, 2018 at 12:16:52AM +0200, Daniel Gustafsson wrote:
> Skimming over SSL code and docs I noticed that we almost always properly
> capitalize “OpenSSL" when referring to the name of the library, using "openssl”
> for when referring to the cli application.  The attached patch fixes the few
> occurrences where the name is referred to, but which aren’t spelled “OpenSSL”.
> Also moves the link to openssl.org to using https:// as it redirects anyways.

I see more that 860 references to openssl as lower case with lots of
noise around file names and translations.  And I can see that you missed
two of them:

contrib/pgcrypto/openssl.c: * Check if strong crypto is supported. Some
openssl installations

src/interfaces/libpq/fe-secure-openssl.c:/* This should exactly match
openssl's SSL_set_fd except for using my BIO */

I don't think that the comments are worth bothering for anything else
than HEAD, now should the doc changes be back-patched?  I would tend to
do so.

Normally I'm the biggest promoter for back-patching documentation changes :) But in the case when it's really just about the capitalization, I think it's fine to just bother with HEAD for it.

--

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Magnus Hagander
Дата:
Сообщение: Re: SCRAM with channel binding downgrade attack
Следующее
От: Peter Eisentraut
Дата:
Сообщение: Re: Listing triggers in partitions (was Re: Remove mention in docsthat foreign keys on partitioned tables)