Re: [HACKERS] invalid combination of options "-D - -F t -X stream" in pg_basebackup

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: [HACKERS] invalid combination of options "-D - -F t -X stream" in pg_basebackup
Дата
Msg-id CABUevEzHoSCoyB1OX0tb=tGwya+qeyRK2zma+e1WDSLgcWdBRA@mail.gmail.com
обсуждение исходный текст
Ответ на [HACKERS] invalid combination of options "-D - -F t -X stream" in pg_basebackup  (Fujii Masao <masao.fujii@gmail.com>)
Ответы Re: [HACKERS] invalid combination of options "-D - -F t -X stream" in pg_basebackup  (Fujii Masao <masao.fujii@gmail.com>)
Список pgsql-hackers
Дерево обсуждения


On Mon, Dec 19, 2016 at 5:39 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
Hi,

Isn't it better to forbid the conbination of the options "-D -", "-F t" and
"-X stream" in pg_basebackup? This is obviously invalid setting and the docs
warns this as follows. But currently users can specify such setting and
pg_basebackup can exit unexpectedly with an error.

-----------------------
If the value - (dash) is specified as target directory, the tar contents will
be written to standard output, suitable for piping to for example gzip.
This is only possible if the cluster has no additional tablespaces.
-----------------------

Yes, definitely. I'd say that's an oversight in implementing the support for stream-to-tar that it did not detect this issue.

Do you want to provide a patch for it, or should I? 

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Fujii Masao
Дата:
Сообщение: [HACKERS] invalid combination of options "-D - -F t -X stream" in pg_basebackup
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: [HACKERS] Quorum commit for multiple synchronous replication.