On Fri, May 25, 2012 at 4:09 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Peter Geoghegan <peter@2ndquadrant.com> writes:
>> On 25 May 2012 14:13, Magnus Hagander <magnus@hagander.net> wrote:
>>> I still think we should consider the placement of this file to not be
>>> in the global/ directory, but this is a quick (back-patchable) fix...
>
>> Where do you suggest the file be written to?
>
> Given that pgstats keeps its permanent file in global/, I think the
> argument that pg_stat_statements should not do likewise is pretty thin.
Fair enough. As long as the file is unlinked after reading (per my
patch), it doesn't cause issues on a standby anymore, so it's a lot
less important, I guess. It's mostly "namespace invasion" at this
time...
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/