On Wed, Aug 29, 2018 at 5:05 PM Magnus Hagander <magnus@hagander.net> wrote: > > On Wed, Aug 29, 2018 at 1:31 PM, Amit Kapila <amit.kapila16@gmail.com> wrote: >> >> So, I think we need to open the file in binary mode as in other parts >> of the code. The attached patch fixes the problem for me. >> >> Thoughts? > > > Yikes. Yes, I believe you are correct, and that looks like the correct fix. > > I wonder why this was not caught on the buildfarm. We do have regression tests for it, AFAIK? >
I am not able to find regression tests for it, but maybe I am not seeing it properly. By any chance, you have removed it during revert of ""Allow on-line enabling and disabling of data checksums".
Oh meh. You are right, it's in the reverted patch, I was looking in the wrong branch :/ Sorry about that. And that certainly explains why we don't have it.