On Mon, Dec 19, 2016 at 7:51 PM, Vladimir Rusinov <vrusinov@google.com> wrote: > > On Sat, Dec 17, 2016 at 2:37 PM, Magnus Hagander <magnus@hagander.net> > wrote: >> >> Attached is an updated patch that does this. As a bonus it simplifies the >> code a bit. I also fixed an error message that I missed updating in the >> previous patch. > > > looks good to me.
Yep, basically looks good to me. Here are some small comments.
Could've sworn I did that, but clearly not. Thanks.
> To create a backup of a single-tablespace local database and compress this with bzip2: > > $ pg_basebackup -D - -Ft | bzip2 > backup.tar.bz2
The above example in the docs needs to be modified. For example, add "-X fetch" into the above command so that pg_basebackup should not exit with an error.
Ah yes, good point as well.
> The server must also be configured with max_wal_senders set high > enough to leave at least one session available for the backup.
I think that it's better to explain explicitly here that max_wal_senders should be higher than one by default.
Added:
The server must also be configured
with <xref linkend="guc-max-wal-senders"> set high enough to leave at least
one session available for the backup and one for WAL streaming (if used).
Will post new patch shortly, once I've addressed Michaels comments as well.