Re: [PATCH] Make pg_basebackup configure and start standby [Review]

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: [PATCH] Make pg_basebackup configure and start standby [Review]
Дата
Msg-id CABUevExfWskjUPUCrYs-+AVzR5noeGWEKc1-9Kq_YYCFcXqCvA@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Make pg_basebackup configure and start standby [Review]  (Boszormenyi Zoltan <zb@cybertec.at>)
Ответы Re: [PATCH] Make pg_basebackup configure and start standby [Review]  (Boszormenyi Zoltan <zb@cybertec.at>)
Список pgsql-hackers

On Fri, Nov 30, 2012 at 10:13 AM, Boszormenyi Zoltan <zb@cybertec.at> wrote:
Hi,

now that PQconninfo() was committed, I rebased the subsequent
patches. Actual code change was only in the last patch, to
conform to the committed PQconninfo() API.

So, finally coming back to this one.

What happened to Alvaro's suggestion of:

> It seems simpler to have the escape_quotes utility function in port just
> not use pg_malloc at all, have it return NULL or similar failure
> indicator when malloc() fails, and then the caller decides what to do.

That way we can get around the whole need for changing memory allocation across all the frontends, no? Like the attached.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/
Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: Re: [PATCH] Change Windows build docs to point to flex and bison from msys
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: PATCH: optimized DROP of multiple tables within a transaction