Re: Bugs in superuser_reserved_connections and max_wal_senders vs max_connections

On Thu, Aug 9, 2012 at 4:17 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> The check in PostmasterMain():
>>       if (ReservedBackends >= MaxBackends)
>>       {
>>               write_stderr("%s: superuser_reserved_connections must be less than
>> max_connections\n", progname);
>>               ExitPostmaster(1);
>>       }
>
>> should probably check against MaxConnections instead of MaxBackends, I think?
>
> Yeah, this code probably dates from before there was a difference.

That was my guess as well.


> In general, I'd bet that this is not the only place where the wrong one
> of those variables is being consulted.

Probably :)

I've fixed this issue. Didn't spot another one with a quick check, but
there's quite possibly something hiding somewhere, yes :)

-- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/