Re: Random PGDLLIMPORTing

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: Random PGDLLIMPORTing
Дата
Msg-id CABUevEx5dgxeVdjbVu+5wgu9g0+eVNZHq4cLcu-zB+hBLfBTnA@mail.gmail.com
обсуждение исходный текст
Ответ на Random PGDLLIMPORTing  (Craig Ringer <craig@2ndquadrant.com>)
Ответы Re: Random PGDLLIMPORTing
Re: Random PGDLLIMPORTing
Список pgsql-hackers
On Thu, Nov 24, 2016 at 2:58 PM, Craig Ringer <craig@2ndquadrant.com> wrote:
Hi all

Noticed this while reading something unrelated

extern PGDLLIMPORT pid_t PostmasterPid;
extern bool IsPostmasterEnvironment;
extern PGDLLIMPORT bool IsUnderPostmaster;
extern bool IsBackgroundWorker;
extern PGDLLIMPORT bool IsBinaryUpgrade;

I don't see any sane reason for some of those to be PGDLLIMPORT but
not others. In particular it's pretty silly for IsBackgroundWorker not
to be PGDLLIMPORT.

Too trivial to be worth making an actual patch, it'd be more work to
apply it than edit directly.

My guess is that PGDLLIMPORT has been added explicitly when somebody needed it for something, without any actual thought. I can't say I see any reason not to export the other ones as well -- more that maybe there are even more that are needed? 

--

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Magnus Hagander
Дата:
Сообщение: Re: Random PGDLLIMPORTing
Следующее
От: Andreas Karlsson
Дата:
Сообщение: Re: [PATCH] Reload SSL certificates on SIGHUP