Re: [HACKERS] src/interfaces/libpq shipping nmake-related Makefiles

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: [HACKERS] src/interfaces/libpq shipping nmake-related Makefiles
Дата
Msg-id CABUevEx04NTJS-x5Goxf1cAduA3bUuZ0GehOGUyqjxuWJ0qxUg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] src/interfaces/libpq shipping nmake-related Makefiles  (Michael Paquier <michael.paquier@gmail.com>)
Ответы Re: [HACKERS] src/interfaces/libpq shipping nmake-related Makefiles
Список pgsql-hackers
Дерево обсуждения
On Tue, Apr 11, 2017 at 4:18 AM, Michael Paquier <michael.paquier@gmail.com> wrote:
On Tue, Apr 11, 2017 at 1:45 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>>>>> Are these votes for getting rid of both win32.mak and bcc32.mak?
>
>> PFA a patch that does this. Did I miss something? :)
>
> Perhaps we should get rid of the WIN32_ONLY_COMPILER symbol altogether;
> given this patch, "#ifdef WIN32_ONLY_COMPILER" could be replaced by
> "#ifdef _MSC_VER".

That's here in the patch for people wondering:
-#if defined(_MSC_VER) || defined(__BORLANDC__)
+#if defined(_MSC_VER)
 #define WIN32_ONLY_COMPILER
 #endif
+1 for the renaming.

Ok, since we have two votes for it, I will go ahead and do that (as a separate patch pushed together).'


> Or maybe rename it to something else --- I'm not sure what, but
> I've always found that symbol rather confusing.

No complains here as well. Thanks for the patch.

Thanks. 


--

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Stephen Frost
Дата:
Сообщение: Re: [HACKERS] pg_dump emits ALTER TABLE ONLY partitioned_table
Следующее
От: Stephen Frost
Дата:
Сообщение: Re: [HACKERS] pgrowlocks relkind check