On Fri, Apr 10, 2015 at 6:39 PM, Magnus Hagander wrote: >> +typedef struct PgBackendSSLStatus >> +{ >> + /* Information about SSL connection */ >> + int ssl_bits; >> + bool ssl_compression; >> + char ssl_version[NAMEDATALEN]; /* MUST be >> null-terminated */ >> + char ssl_cipher[NAMEDATALEN]; /* MUST be >> null-terminated */ >> + char ssl_clientdn[NAMEDATALEN]; /* MUST be >> null-terminated */ >> +} PgBackendSSLStatus; >> git diff is showing in red here, spaces should be replaced with a tab. > > > Ugh. Fixed. One too many copy/pastes I think. >
You forgot one here: + /* Information about SSL connection */
In other news, I have now fixed my git to show these things to be again. It used to do that, but I broke it :)
Thanks!
Except for those style comments (feel free to ignore them), I tested the patch and it is doing what it claims. As I don't have more comments, let's switch that to "Ready for Committer" then...