Re: Feature request: Logging SSL connections

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: Feature request: Logging SSL connections
Дата
Msg-id CABUevEwXC+3YR8vvOgd9fpKpHaAXgBDhdhuR6tbp2+FeKyke2Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Feature request: Logging SSL connections  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Fri, Jan 17, 2014 at 4:53 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Magnus Hagander <magnus@hagander.net> writes:
> Applied, thanks!

Minor bikeshedding: the messages would read better, to my eye, as

"user=%s database=%s SSL enabled (protocol=%s, cipher=%s)"

Putting "enabled" where it is requires extra mental gymnastics on
the part of the reader.  And why the random change between "="
in one part of the string and ": " in the new part?  You could take
that last point a bit further and make it

Makes sense.


"user=%s database=%s SSL=enabled (protocol=%s, cipher=%s)"

but I'm not sure if that's an improvement.

I don't think it is, so I've applied the first suggestion. 

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Rowley
Дата:
Сообщение: Re: [PATCH] Negative Transition Aggregate Functions (WIP)
Следующее
От: Dean Rasheed
Дата:
Сообщение: Re: array_length(anyarray)