Re: [PATCH] pgweb: Add SEARCH_DSN to example settings.py

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: [PATCH] pgweb: Add SEARCH_DSN to example settings.py
Дата
Msg-id CABUevEw+gtEVa1sq0H5FMXuYnm1EXU6mxaqLaYn42tindmCAyQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] pgweb: Add SEARCH_DSN to example settings.py  ("Jonathan S. Katz" <jkatz@postgresql.org>)
Ответы Re: [PATCH] pgweb: Add SEARCH_DSN to example settings.py  (Célestin Matte <celestin.matte@cmatte.me>)
Список pgsql-www
Дерево обсуждения


On Fri, Oct 22, 2021 at 6:10 PM Jonathan S. Katz <jkatz@postgresql.org> wrote:
On 10/22/21 11:08 AM, Célestin Matte wrote:
> Hello,
>
> Defining SEARCH_DSN is necessary to install the search functionality in pgweb, although this is not explained anywhere.
> This patch adds SEARCH_DSN in the example settings.py so that users know that this variable must be defined.

...this perhaps explains why I've never gotten the search utility to
work in my local environment.

In general I'm OK with this, but perhaps we leave the string empty with
instructions to fill the connection string to the DB that is hosting the
search schema.

I think having a default like in this patch is better. Otherwise it could randomly connect to a database with the same name as the user for example, which might actually happen in dev scenarios. So if we want it empty we'd also need to add code to check if it's set or not before trying to use it - seems easier to set the default and have it fail :)

--

В списке pgsql-www по дате отправления:

Предыдущее
От: "Jonathan S. Katz"
Дата:
Сообщение: Re: [PATCH] pgweb: Add SEARCH_DSN to example settings.py
Следующее
От: Magnus Hagander
Дата:
Сообщение: Re: [PATCH] pgweb: Search: bugfix: replace sites.baseurl with sites.hostname