Re: pg_restore: show object schema name in verbose output

2013/8/4 Erik Rijkers <er@xs4all.nl>:
> On Sun, August 4, 2013 04:51, Ian Lawrence Barwick wrote:
>> I just noticed that pg_restore executing in "verbose" mode displays the
>> name of the object being restored, but not its schema.
>>
>
> Good idea.  We have many schemata with tables of the same name and
> reporting the schema name certainly improves the readability and error
> trackdown during restore.
>
> I notice 2 things:
>
>
> 1.  pg_restore now outputs reports about COMMENT like this:
> pg_restore: creating COMMENT restore_verbose_test.TABLE t
> pg_restore: creating COMMENT restore_verbose_test.COLUMN t.c
> pg_restore: creating COMMENT restore_verbose_test.COLUMN t.i
>
> I assume the .TABLE and .COLUMN here is a bug; it should just be:
>
> pg_restore: creating COMMENT restore_verbose_test t
>
> as it used to be.
>
>
> 2.  Several of the lines that are output by pg_restore now mention
> the schema, but not the "processing" line:
>
> pg_restore: processing data for table "t"
>
> Could it be added there too?

Thanks for the feedback and test case. I'll submit a revised patch.

Regards

Ian Barwick