On Thu, Jan 24, 2013 at 3:41 AM, Andres Freund
<andres@2ndquadrant.com> wrote:
I think the usage of list_append_unique_oids in
ReindexRelationsConcurrently might get too expensive in larger
schemas. Its O(n^2) in the current usage and schemas with lots of
relations/indexes aren't unlikely candidates for this feature.
The easist solution probably is to use a hashtable.
I just had a look at the hashtable APIs and I do not think it is adapted to establish the list of unique index OIDs that need to be built concurrently. It would be of a better use in case of mapping the indexOids with something else, like the concurrent Oids, but still even with that the code would be more readable if let as is.
--
Michael Paquier
http://michael.otacoo.com