On Fri, Nov 11, 2016 at 11:03 PM, Albe Laurenz <laurenz.albe@wien.gv.at> wrote:
> - In pg_dumpall.c, the result of fsync_fname() is cast to "void" to show that
> the return code is ignored, but not anywhere else. Is that by design?
Right. The patch is lacking consistency in this area. The main thought
regarding this design is to not consider a fsync failure as critical,
and just issue a warning in stderr. I have updated the two other call
sites with a (void) cast.
> - For pg_dumpall, a short option "-N" is added for "--no-sync", but not for
> pg_dump (because -N is already taken there).
> I'd opt for either using the same short option for both or (IMO better)
> only offering a long option for both.
Okay. For consistency's sake let's do that. I was a bit hesitant
regarding that to be honest.
> This would avoid confusion, and we expect that few people will want to use
> this option anyway, right?
Definitely a good point.
--
Michael