Re: Small issues in syncrep.c

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Small issues in syncrep.c
Дата
Msg-id CAB7nPqTitHAkqLXNEGrwgxovBe3byBi_gJwfvkkEaQCv-qxc9w@mail.gmail.com
обсуждение исходный текст
Ответ на Small issues in syncrep.c  (Julien Rouhaud <julien.rouhaud@dalibo.com>)
Ответы Re: Small issues in syncrep.c  (Simon Riggs <simon@2ndquadrant.com>)
Список pgsql-hackers
On Tue, Aug 9, 2016 at 5:34 PM, Julien Rouhaud
<julien.rouhaud@dalibo.com> wrote:
> Since 14e8803f1, it's not necessary to acquire the SyncRepLock to see up
> to date data. But it looks like this commit didn't update all the
> comment around MyProc->syncRepState, which still mention retrieving the
> value without and without lock.  Also, there's I think a now unneeded
> test to try to retrieve again syncRepState.
>
> Patch attached to fix both small issues, present since 9.5.

You could directly check MyProc->syncRepState and remove syncRepState.
Could you add it to the next commit fest? I don't think this will get
into 9.6 as this is an optimization.
-- 
Michael



В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Tsunakawa, Takayuki"
Дата:
Сообщение: Re: Wait events monitoring future development
Следующее
От: Pavel Stehule
Дата:
Сообщение: Re: PL/Python adding support for multi-dimensional arrays