Re: [HACKERS] Function to move the position of a replication slot

On Thu, Aug 31, 2017 at 9:19 PM, Magnus Hagander <magnus@hagander.net> wrote:
> PFA an updated and rebased patch.
>
> Rebased. Now named pg_advance_replication_slot. ERROR on logical slots.
> Forward only.
>
> I think that, in the end, covered all the comments?

+   if (backwards)
+       ereport(WARNING,
+               (errmsg("Not moving replication slot backwards!")));
Shouldn't this be an ERROR, mentioning the current position of the slot?

+        ereport(ERROR,
+                (errmsg("Only physical replication slots can be advanced.")));
ERRCODE_FEATURE_NOT_SUPPORTED, no?
-- 
Michael