On Thu, Sep 29, 2016 at 7:18 PM, Jeevan Chalke
<jeevan.chalke@enterprisedb.com> wrote:
> Hi Stephen,
>
>
>> > 4. It will be good if we have an example for this in section
>> > "5.7. Row Security Policies"
>>
>> I haven't added one yet, but will plan to do so.
>>
> I think you are going to add this in this patch itself, right?
>
> I have reviewed your latest patch and it fixes almost all my review
> comments.
> Also I am agree with your responses for couple of comments like response on
> ALTER POLICY and tab completion. No issues with that.
>
> However in documentation, PERMISSIVE and RESTRICTIVE are actually literals
> and not parameters as such. Also can we combine these two options into one
> like below (similar to how we document CASCADE and RESTRICT for DROP
> POLICY):
>
> <varlistentry>
> <term><literal>PERMISSIVE</literal></term>
> <term><literal>RESTRICTIVE</literal></term>
>
> <listitem>
> <para>
> ... explain PERMISSIVE ...
> </para>
> <para>
> ... explain RESTRICTIVE ...
> </para>
> </listitem>
> </varlistentry>
>
> Apart from this changes look excellent to me.
I have moved that to next CF, my guess is that Stephen is going to
update soon and the activity is fresh.
--
Michael