Simplify calls of pg_class_aclcheck when multiple modes are used

Поиск

Список

Период

Сортировка

От	Michael Paquier
Тема	Simplify calls of pg_class_aclcheck when multiple modes are used
Дата	27 августа 2014 г. 15:02:49
Msg-id	CAB7nPqTX3rRAaFTbe1h=PnUe7VO6+Q12VEZOf3qUNqmFDpL1vA@mail.gmail.com обсуждение исходный текст
Ответы	Re: Simplify calls of pg_class_aclcheck when multiple modes are used (Fabrízio de Royes Mello <fabriziomello@gmail.com>) Re: Simplify calls of pg_class_aclcheck when multiple modes are used (Peter Eisentraut <peter_e@gmx.net>)
Список	pgsql-hackers

Дерево обсуждения

Hi all,

In a couple of code paths we do the following to check permissions on an object:
if (pg_class_aclcheck(relid, userid, ACL_USAGE) != ACLCHECK_OK &&
pg_class_aclcheck(relid, userid, ACL_UPDATE) != ACLCHECK_OK)

ereport(ERROR, blah);

Wouldn't it be better to simplify that with a single call of pg_class_aclcheck, gathering together the modes that need to be checked? In the case above, the call to pg_class_aclcheck would become like that:
if (pg_class_aclcheck(relid, userid,
ACL_USAGE | ACL_UPDATE) != ACLCHECK_OK)
ereport(ERROR, blah);

That's not a critical thing, but it would save some cycles. Patch is attached.

Regards,

--
Michael