On Tue, Mar 10, 2015 at 2:50 AM, Michael Meskes <meskes@postgresql.org> wrote:
> On 09.03.2015 16:58, Tom Lane wrote:
>> Andrew Dunstan <andrew@dunslane.net> writes:
>>> The MSVC build creates project directories which contain all the .obj
>>> files etc. The file locations for intermediate artefacts are quite
>>> different from the way a Unix build works. There is an ignore rule for
>>> these directories, which covers the .obj files there. But ecpg files are
>>> generated like in Unix builds.
>>
>> Ah. That's lots more plausible than "no one's ever done any development
>> on Windows". I can believe that not so many people have run the ecpg
>> tests there.
>
> Completely agreed.
>
>>> Since we have a global ignore rule for .o
>>> files it makes plenty of sense to have one for .obj files also.
>>> Certainly better than have one rule for each ecpg test case.
>>
>> Agreed. So we should revert the previous patch ...
>
> Done.
Thanks for the fix. I did it as a global rule first, until noticing
that each regression item was listed in their own separate
.gitignore..
--
Michael