Re: pgsql: psql: fix \connect with URIs and conninfo strings

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: pgsql: psql: fix \connect with URIs and conninfo strings
Дата
Msg-id CAB7nPqSTzO1rex5nMZXvw-ywgO3T2oV_oSA12m9un12bbDz=AA@mail.gmail.com
обсуждение исходный текст
Ответ на pgsql: psql: fix \connect with URIs and conninfo strings  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Ответы Re: pgsql: psql: fix \connect with URIs and conninfo strings  (Michael Paquier <michael.paquier@gmail.com>)
Список pgsql-committers
Дерево обсуждения


On Thu, Apr 2, 2015 at 8:10 AM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
psql: fix \connect with URIs and conninfo strings

psql was already accepting conninfo strings as the first parameter in
\connect, but the way it worked wasn't sane; some of the other
parameters would get the previous connection's values, causing it to
connect to a completely unexpected server or, more likely, not finding
any server at all because of completely wrong combinations of
parameters.

This patch has broken the build on OSX:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dromedary&dt=2015-04-02%2000%3A10%3A54
My box complains as well.

I haven't looked at that in details, but it looks that there are linking problems with -lpgcommon, as it is the first time that libpq has a dependency with it.

I am seeing as well that this is at least missing at the top of connstring.c:
#ifndef FRONTEND
#error "This file is not expected to be compiled for backend code"
#endif
And that src/tools/msvc has not been updated to have connstring.c show up in the list of frontend-only objects for libpgcommon.
--
Michael

В списке pgsql-committers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: pgsql: psql: fix \connect with URIs and conninfo strings
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: pgsql: psql: fix \connect with URIs and conninfo strings