Re: Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)
Дата
Msg-id CAB7nPqSA0aPegJD0_5+1iwkZZk4+1d7nuWhPYwwwjVXAJUZg2w@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)  (Andres Freund <andres@2ndquadrant.com>)
Ответы Re: Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)  (Andres Freund <andres@2ndquadrant.com>)
Список pgsql-hackers


On Mon, Sep 29, 2014 at 7:50 PM, Andres Freund <andres@2ndquadrant.com> wrote:
What about the attached patch then?

Thanks for this update. This looks good. Here are a couple of small comments:
1) This sentence is correct English, but I don't recall seeing in the docs such a formulation:
+        Can only be used on slots using a output plugin supporting textual
+        output.
I'd rather rewrite 'It can only be used' or 'this function can only be used'. I imagine that you could add a reference to logicaldecoding-output-mode as well.
2) s/a output/an output/g
3) The formulation here seems vague as a plugin that generates textual output can call pg_logical_slot_peek_binary_changes as well:
-        except that changes are returned as <type>bytea</type>.
+        except that changes are returned as <type>bytea</type> and that it can
+        be used on slots using output plugins that only support binary output.
4) What about reformulating the following:
+     so a <type>text</> can contain it. This is checked in assertion enabled
+     builds.
"This is checked in builds with assertions enabled."
5) Better to add a newline between two portions sect2.
+   </sect2>
    <sect2 id="logicaldecoding-output-plugin-callbacks">

Regards,
--
Michael

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: pg_receivexlog and replication slots
Следующее
От: Michael Paquier
Дата:
Сообщение: Re: pg_receivexlog and replication slots