On Wed, Nov 15, 2017 at 10:17 AM, Nikita Glukhov
<n.gluhov@postgrespro.ru> wrote:
> Attached the new version of the patches where displaying of SQL/JSON
> constructor nodes was fixed. I decided not to invent new nodes but to
> extend
> existing FuncExpr, Aggref, WindowFunc nodes with new formatting fields that
> give us ability to override default displaying in ruleutils.c. Also new
> invisible CoercionForm was added for hiding casts in which FORMAT and
> RETUNING
> clauses are transformed.
Okay, I can see that the patch is still in the same situation two
weeks after I looked at it first, so I am marking it as returned with
feedback. This needs to be broken down, and get documentation. At this
point getting a review out of this patch is not something I'd
recommend until it is put in a shape that makes it easier. Please also
help in reviewing other's patches, yours here is very large.
--
Michael