Re: [PATCH] Allow TAP tests to be run individually

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: [PATCH] Allow TAP tests to be run individually
Дата
Msg-id CAB7nPqRj-Q1047Z0E=6rJZLk-FZKk-oAqgd6tpzR9aNTyOqHvw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Allow TAP tests to be run individually  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Список pgsql-hackers
On Tue, Nov 15, 2016 at 12:02 AM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
> On 11/14/16 3:52 AM, Michael Paquier wrote:
>> I don't mind. This patch uses the following pattern:
>> $(or $(PROVE_TESTS),t/*.pl)
>> While something more spread in Postgres source would be something like that:
>> $(if $(PROVE_TESTS),$(PROVE_TESTS),t/*.pl)
>> It seems to me that we'd prefer that for consistency, but I see no
>> reason to not keep your patch as well. I am marking that as ready for
>> committer.
>
> ($or ...) is a newer feature of GNU make, so we have avoided that so
> far.  I have committed your v2 with $(if ...).

Thanks, I am just going to use it...
-- 
Michael



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Something is broken about connection startup
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Do we need use more meaningful variables to replace 0 in catalog head files?