Re: Suspicious check (src/backend/access/gin/gindatapage.c)

On Fri, Sep 12, 2014 at 7:35 AM, Gaetano Mendola <mendola@gmail.com> wrote:
> At line 650 I can read:
>
>  if ((leaf->lsize - segsize) - (leaf->lsize - segsize) < BLCKSZ / 4)
>          break;
>
> I believe one of the two should be leaf->rsize
Yes this condition is broken. Shouldn't it be that instead when
appending items at the end of a page?
if ((leaf->lsize - segsize) - (leaf->rsize + segsize) < BLCKSZ / 4)
This has been introduced by 36a35c5 and should be backpatched to 9.4.
Regards,
--
Michael