On Fri, Jan 6, 2017 at 1:07 PM, Craig Ringer <craig@2ndquadrant.com> wrote:
> On 5 January 2017 at 13:12, Michael Paquier <michael.paquier@gmail.com> wrote:
>> On Thu, Jan 5, 2017 at 10:21 AM, Craig Ringer <craig@2ndquadrant.com> wrote:
>>> On 5 January 2017 at 09:19, Craig Ringer <craig@2ndquadrant.com> wrote:
>>>
>>>> so here's a rebased series on top of master. No other changes.
>>>
>>> Now with actual patches.
>>
>> Looking at the PostgresNode code in 0001...
>> +=pod $node->pg_recvlogical_upto(self, dbname, slot_name, endpos,
>> timeout_secs, ...)
>> +
>> This format is incorrect. I think that you also need to fix the
>> brackets for the do{} and the eval{] blocks.
>>
>> + push @cmd, '--endpos', $endpos if ($endpos);
>> endpos should be made a mandatory argument. If it is not defined that
>> would make the test calling this routine being stuck.
>
> Acknowledged and agreed. I'll fix both in the next revision. I'm
> currently working on hot standby replies, but will return to this
> ASAP.
By the way, be sure to fix as well the =pod blocks for the new
routines. perldoc needs to use both =pod and =item.
--
Michael