Re: Several problems in tab-completions for SET/RESET

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Several problems in tab-completions for SET/RESET
Дата
Msg-id CAB7nPqRHRGNv9N9r6R2xCCjY5kcDSpap41FTBErSpWcOv7HKtw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Several problems in tab-completions for SET/RESET  (Fujii Masao <masao.fujii@gmail.com>)
Ответы Re: Several problems in tab-completions for SET/RESET
Список pgsql-hackers
On Fri, Jan 29, 2016 at 11:53 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> I removed the above and added the following for that case.
>
> +    /* Complete ALTER DATABASE|FUNCTION|ROLE|USER ... SET <name> */
> +    else if (Matches2("ALTER", "DATABASE|FUNCTION|ROLE|USER") &&
> +             TailMatches2("SET", MatchAny))
> +        COMPLETE_WITH_LIST2("FROM CURRENT", "TO");
>
> Attached is the updated version of the patch.

"ALTER FUNCTION foo(bar)" suggests OWNER TO, RENAME TO and SET SCHEMA.
I think that we had better suggesting SET instead of SET SCHEMA, and
add SCHEMA in the list of things suggested by SET.

"ALTER DATABASE foodb SET foo_param" should suggest TO/= but that's
not the case. After adding TO/= manually, a list of values is
suggested though. Same problem with ALTER ROLE and ALTER FUNCTION.

> I also added the change that Sawada suggested, to the patch.

OK.
-- 
Michael



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kouhei Kaigai
Дата:
Сообщение: Re: CustomScan in a larger structure (RE: CustomScan support on readfuncs.c)
Следующее
От: Robert Haas
Дата:
Сообщение: Re: postgres_fdw join pushdown (was Re: Custom/Foreign-Join-APIs)