On Tue, Nov 8, 2016 at 9:32 PM, David Steele <david@pgmasters.net> wrote:
> I had a bit of trouble parsing this paragraph:
>
> [...]
>
> So I did a little reworking:
>
> [...]
>
> If that still says what you think it should, then I believe it is clearer.
Thanks! I have included your suggestion.
> Also:
>
> + * last time a segment has switched because of a timeout.
> Segment
> + * switching because of other reasons, like manual
> trigerring of
>
> typo, should be "triggering".
Right.
> I don't see any further issues with this patch unless there are performance
> concerns about the locks taken in GetProgressRecPtr(). The locks seem
> reasonable to me but I'd like to see this committed so there's plenty of
> time to detect any regression before 10.0.
>
> As such, my vote is to mark this "Ready for Committer." I'm fine with
> waiting a few days as Kyotaro suggested, or we can consider my review
> "additional comments" and do it now.
Thanks for the review! Waiting for a couple of days more is fine for
me. This won't change much. Attached is v15 with the fixes you
mentioned.
--
Michael