On Tue, Dec 22, 2015 at 5:34 PM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> I wrote:
>> Wouldn't it be better with something say in src/common
>> which is frontend-only? We could start with a set of routines allowing
>> commands to be parsed. That gives us more room for future improvement.
>
> If I read you correctly, I should cut it out into a new file and
> include it. Is it correct?
Not really, I meant to see if it would be possible to include this set
of routines directly in libpqcommon (as part of OBJS_FRONTEND). This
way any client applications could easily reuse it. If we found that
what was in psql is now useful to pgbench, I have little doubt that
some other folks would make good use of that. I honestly have not
looked at the code to see if that's doable or not, but soft-linking
directly in pgbench a file of psql will not help future maintenance
for sure. This increases the complexity of the code.
--
Michael