On Thu, Apr 24, 2014 at 8:31 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> Oh OK. I'll try to get a clean patch following those lines. There is
> as well the AddDir call for contrib/ to add...
I went through those things, resulting in the following set of patches:
- 20140425_msvc_adddir.patch, adding some AddDir for contrib modules
to be able to detect PGFILEDESC and generate resource files in
consequence.
- 20140425_pgfiledesc_contrib.patch, adding PGFILEDESC to all the
modules that actually need it (PL things, snowball, contrib/, etc.)
- 20140425_pgfiledesc_cvprocs.patch, adding PGFILEDESC to all the
modules in conversion_procs. OK this does not ease the maintenance
pain, but for correctness in the file version of a build this is
important.
Patch 1 should be definitely applied, that's an existing bug. Patch 2
and 3 are here to ensure that all the dll/exe files generated have a
version number associated with a build on Windows, something
particularly useful for upgrades, and important for consistency among
files...
Regards,
--
Michael