Re: Bug in searching path in jsonb_set when walking through JSONB array

Поиск
Список
Период
Сортировка
От Michael Paquier
Тема Re: Bug in searching path in jsonb_set when walking through JSONB array
Дата
Msg-id CAB7nPqQTD6nGfJnhBadoSx72Vcxejp_3dwGB+hfExh3o_V-umQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Bug in searching path in jsonb_set when walking through JSONB array  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Wed, Mar 23, 2016 at 11:01 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Michael Paquier <michael.paquier@gmail.com> writes:
>> That's ugly. We should actually use TextDatumGetCString because the
>> index is stored as text here via a Datum, and then it is converted
>> back to an integer. So I propose instead the simple patch attached
>> that fixes the failure for me. Could you check if that works for you?
>
> Yeah, this seems better.  But that code needs review anyway, as it's using
> elog() for user-facing error conditions, and I'm thinking the error texts
> could use a bit of attention from a native English speaker.

Thanks. The bug fix is 384dfbd, and the improvements of error messages
is ea4b8bd.
-- 
Michael



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: Speed up Clog Access by increasing CLOG buffers
Следующее
От: Peter Geoghegan
Дата:
Сообщение: Re: PoC: Partial sort