On Fri, Jan 6, 2017 at 1:31 AM, Vladimir Rusinov <vrusinov@google.com> wrote:
> Attaching a patch that renames all 'xlog' functions, keeping aliases for old
> ones (since it looks like majority vote is for keeping them).
OK.
> - OIDs - where do I get numbers from? I was kinda choosing them at random,
> unaware if there is some process for keeping track of them. Please point me
> if such thing exists and I'll change them.
You can use src/include/catalog/unused_oids to look at the OIDs not
yet assigned. Assigning them logically increasing may be a good idea.
But OID ordering is not that mandatory for the internal functions and
operators.
> - Documentation. I've added a new section with a simple table, keeping it
> somewhat neglected on purpose. We'll have old names in index and searchable
> on page, but nothing more. Is it sufficient?
I find quite clear what you have produced here. The table states
clearly the one-one mapping between the old and new entries.
> - New function names. I've used 'recovery' instead of 'xlog_replay'
I would not have touched this one. But if we go this way, let's
bike-shed and use pg_recovery_ as prefix for consistency.
> and used 'wal_file' instead of 'xlogfile'. Does it make sense?
This one yes.
For simplicity I would just have done a s/xlog/wal/ and keep the names
consistent a maximum with the old ones. But I am just working here.
You clearly put thoughts in the new names.
> - Release notes. I was unable to find a draft for 10.0. How do I make sure
> these renames are not forgotten?
That's part of the job of the release note writer, very likely Tom or
Bruce. The commit message should be explicit enough that the writer
does not have to dig into the code itself for the changes.
--
Michael